Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument

From: Greg Kroah-Hartman
Date: Tue Apr 02 2019 - 07:10:08 EST


On Tue, Apr 02, 2019 at 02:00:06AM -0700, Joe Perches wrote:
> On Tue, 2019-04-02 at 08:59 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote:
> > > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote:
> > > > 4.4-stable review patch. If anyone has any objections, please let me know.
> > >
> > > If this is to be ported just for an optimization
> > > (which I think is dubious as it's not a bug fix),
> >
> > Yes, it was requested to be backported because of that.
> >
> > > why not port the __fls optimization too?
> > >
> > > __fls has a bigger effect on performance.
> >
> > What commit are you referring to?
>
> f8ae107eef209bff29a5816bc1aad40d5cd69a80

Thanks for the commit id, I'll look into adding that to a later round of
kernel releases.

greg k-h