Re: [PATCH v5 2/7] slob: Respect list_head abstraction layer

From: Christopher Lameter
Date: Wed Apr 03 2019 - 11:45:40 EST


On Wed, 3 Apr 2019, Tobin C. Harding wrote:

> Currently we reach inside the list_head. This is a violation of the
> layer of abstraction provided by the list_head. It makes the code
> fragile. More importantly it makes the code wicked hard to understand.

Great.... It definitely makes it clearer. The boolean parameter is not
so nice but I have no idea how to avoid it in the brief time I spent
looking at it.

Acked-by: Christoph Lameter <cl@xxxxxxxxx>