Re: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority

From: Doug Anderson
Date: Wed Apr 03 2019 - 14:17:43 EST


Hi,

On Wed, Apr 3, 2019 at 11:14 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> Each transfer has it's own work struct (allocated on the stack), hence
> a) does not occur. b) is still true, but shouldn't be a problem on
> its own.

Actually, it could be much worse _because_ it's on the stack. The
worker could write something back to the work after the work has been
de-allocated. That's bad.


> Anyway, using flush_work() as you suggested is the better solution :)

Yup, thanks!