Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

From: Alex Kogan
Date: Wed Apr 03 2019 - 23:15:33 EST


Hi, Hanjun.

> On Apr 3, 2019, at 10:02 PM, Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
>
> Hi Alex,
>
> On 2019/3/29 23:20, Alex Kogan wrote:
>> +
>> +static __always_inline void cna_init_node(struct mcs_spinlock *node, int cpuid,
>> + u32 tail)
>> +{
>> + if (decode_numa_node(node->node_and_count) == -1)
>> + store_numa_node(node, numa_cpu_node(cpuid));
>
> How about using cpu_to_node() here and #include <linux/topology.h> in this
> file, then the code can be reused for other architectures such as ARM64?
Good point. Thanks!

â Alex

>
> Thanks
> Hanjun
>