Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

[Jacek Anaszewski]

Hi Tony,

Thanks for the feedback.

On 4/4/19 2:09 AM, Tony Lindgren wrote:
> * Dan Murphy <dmurphy@xxxxxx> [190321 14:29]:
> > Introduce the Texas Instruments LM3532 White LED driver.
> > The driver supports ALS configurability or manual brightness
> > control.
> >
> > The driver also supports associating LED strings with specific
> > control banks in a group or as individually controlled strings.
>
> I'm seeing slightly different naming under /sys/class/leds:
>
> lm3532:backlight
> lm3532:platform::kbd_backlight

The problem is in the "platform:" being a part of DT
label property. It should not be included there if devicename
section is added in the driver.

> Not sure if this is correct with the the "platform" and
> "::" there for the kbd_backlight?
>
> With the dts change I posted, I've tested this with
> linux-next and Sebastian's DSI command mode patches
> "[PATCHv6 0/4] omapdrm: DSI command mode panel support".
>
> So feel free to add:
>
> Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>

--
Best regards,
Jacek Anaszewski