Re: [PATCH] tcp: remove redundant check on tskb

[Eric Dumazet]

On Thu, Apr 4, 2019 at 7:46 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The non-null check on tskb is always false because it is in an else
> path of a check on tskb and hence tskb is null in this code block.
> This is check is therefore redundant and can be removed as well
> as the label coalesc.
>...

> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

SGTM, thanks.

Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>