Re: [PATCH 04/14] x86 topology: Add CPUID.1F multi-die/package support

From: Thomas Gleixner
Date: Fri Apr 05 2019 - 14:16:12 EST


On Thu, 28 Feb 2019, Len Brown wrote:
> On Tue, Feb 26, 2019 at 2:46 PM Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
> > I wonder if we'll end up with different (better) infrastructure if we do
> > these all at once instead of hacking them in one at a time.
>
> Assuming that "hacking in" is a derogatory term, let me make the case
> that this patch series cleanly sets the stage for the future.
>
> old:
>
> thread_siblings: the threads that are in the same core
> core_siblings: the threads that are in the same package
>
> This naming scheme assumed that there would never be a topology level
> between a core and a package. Though we leave "core_siblings" intact
> for legacy SW that depends on it, we mark it depreciated.
>
> new:
>
> core_threads: the threads in the same core
> die_threads: the threads in the same die
> package_threads: the threads in the same package
>
> So in the future we could always add...
>
> dave_threads: the threads in the same dave
>
> So I think we are ready for whatever the future may throw at us,
> while remaining compatible, consistent, and no "hacking in" required.

Makes sense.

tglx