Re: [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()

From: Rafael J. Wysocki
Date: Mon Apr 08 2019 - 06:42:02 EST


On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote:
> The success path and error path both look the same, don't duplicate the
> code.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> drivers/cpufreq/maple-cpufreq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/maple-cpufreq.c
> b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644
> --- a/drivers/cpufreq/maple-cpufreq.c
> +++ b/drivers/cpufreq/maple-cpufreq.c
> @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
>
> rc = cpufreq_register_driver(&maple_cpufreq_driver);
>
> - of_node_put(cpunode);
> -
> - return rc;
> -
> bail_noprops:
> of_node_put(cpunode);

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

I'm assuming this to land in your tree.