RE: [PATCH] net: lan78xx: fix "enabled interrupts" warninig

From: RaghuramChary.Jallipalli
Date: Mon Apr 08 2019 - 06:46:58 EST


> > Is this warning specific to any linux version?
>
> In theory, no. I only tested 5.0, 4.20, both can reproduce this warning.
>
This makes me think that code is fine because it occurs in 4.20 and greater. Or maybe the problem is masked in older. I maybe wrong in assuming that.

>
> The warning comes from calling generic_handle_irq() in usb tasklet context.
> This is not correct.
>
> Per my understanding, if there's chained irq, we could introduce extra
> irqdomain. E.g
>
> GIC <--> another irqchip controller <--> HW device
>
Correct, IRQ domain is generally used in chained irq controllers.
Yes, We need to check why irq domain is used in the current driver.

Thanks