Re: [PATCH 2/7] watchdog/sbsa: Use arch_timer_read_counter instead of arch_counter_get_cntvct

From: Guenter Roeck
Date: Mon Apr 08 2019 - 14:07:56 EST


On Mon, Apr 08, 2019 at 04:49:02PM +0100, Marc Zyngier wrote:
> Only arch_timer_read_counter will guarantee that workarounds are
> applied. So let's use this one instead of arch_counter_get_cntvct.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

... assuming/hoping that those counters are actually the same.

Guenter

> ---
> drivers/watchdog/sbsa_gwdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index e8bd9887c566..e221e47396ab 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -161,7 +161,7 @@ static unsigned int sbsa_gwdt_get_timeleft(struct watchdog_device *wdd)
> timeleft += readl(gwdt->control_base + SBSA_GWDT_WOR);
>
> timeleft += lo_hi_readq(gwdt->control_base + SBSA_GWDT_WCV) -
> - arch_counter_get_cntvct();
> + arch_timer_read_counter();
>
> do_div(timeleft, gwdt->clk);
>
> --
> 2.20.1
>