Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu
From: Borislav Petkov
Date: Mon Apr 08 2019 - 16:34:42 EST
On Mon, Apr 08, 2019 at 01:26:59PM -0700, Luck, Tony wrote:
> On Mon, Apr 08, 2019 at 02:12:17PM +0000, Ghannam, Yazen wrote:
> > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks);
> > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks);
> The name "num_banks" is a bit generic for an exported symbol.
> I think it should have a "mce_" prefix.
Actually, it should not be exported at all. A function returning the num
banks is better instead.
Good mailing practices for 400: avoid top-posting and trim the reply.