Re: [PATCH v2 1/2] cpuidle : auto-promotion for cpuidle states

From: Abhishek
Date: Tue Apr 09 2019 - 05:36:59 EST


Hi Daniel,

On 04/08/2019 07:55 PM, Daniel Axtens wrote:
Hi,

Sorry, just realised another thing I wanted to ask:

@@ -442,6 +442,26 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
}
}


+#ifdef CPUIDLE_FLAG_AUTO_PROMOTION
Why is this based on CPUIDLE_FLAG_ rather than CONFIG_CPU_IDLE_? Won't
this always be true, given that the flag is defined regardless of the
config option in the header?
Yeah, You are right. This should have been CONFIG_CPU_IDLE_AUTO_PROMOTION.

--Abhishek