Re: [PATCH 1/2] ASoC: fsl_audmix: remove "model" attribute
From: Daniel Baluta
Date: Tue Apr 09 2019 - 06:05:47 EST
Few comments inline.
On Tue, Apr 9, 2019 at 11:36 AM Viorel Suman <viorel.suman@xxxxxxx> wrote:
> Use "of_device_id.data" to specify the machine driver,
> instead of "model" DTS attribute.
> static int fsl_audmix_probe(struct platform_device *pdev)
> + struct device *dev = &pdev->dev;
You might want to remove this change from the patch because it touches
a lot of lines
and it makes the review harder.
I don't see any reason to have it at all.