Re: [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

From: Arnaldo Carvalho de Melo
Date: Tue Apr 09 2019 - 11:01:47 EST


Em Tue, Apr 09, 2019 at 09:25:57AM +0300, Adrian Hunter escreveu:
> Fix following error using calls_view:
> Query failed: ambiguous column name: parent_id Unable to execute statement
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Applied, and thanks for the Fixes tag, appreciated,

- Arnaldo

> Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
> ---
> tools/perf/scripts/python/export-to-sqlite.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
> index 3b71902a5a21..bf271fbc3a88 100644
> --- a/tools/perf/scripts/python/export-to-sqlite.py
> +++ b/tools/perf/scripts/python/export-to-sqlite.py
> @@ -331,7 +331,7 @@ if perf_db_export_calls:
> 'return_id,'
> 'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
> 'parent_call_path_id,'
> - 'parent_id'
> + 'calls.parent_id'
> ' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
>
> do_query(query, 'CREATE VIEW samples_view AS '
> --
> 2.17.1

--

- Arnaldo