Re: [PATCH v2 3/4] docs: Remove unnecessary reference link title
From: Jonathan Corbet
Date: Tue Apr 09 2019 - 17:20:33 EST
On Tue, 9 Apr 2019 10:43:58 +1000
"Tobin C. Harding" <tobin@xxxxxxxxxx> wrote:
> Labels that precede a heading use the heading as the link title.
> Explicitly adding the link title is redundant and makes the reference
> slightly less maintainable.
>
> Remove unnecessary reference link title.
So I agree with the objective, but...
> - As mentioned above in :ref:`VMA policies <vma_policy>` section,
> + As mentioned above in :ref:`vma_policy` section,
...this one generates a warning that highlights a flaw in the reasoning
here:
Documentation/admin-guide/mm/numa_memory_policy.rst:144: WARNING:
undefined label: vma-policy (if the link has no caption the label
must precede a section header)
Said label does not precede a section header, so it can't be used bare in
this way.
I'll apply the other three, but this one needs some repairs :)
Thanks,
jon