Re: [PATCH v3 2/9] kbuild: Support for Symbols.list creation

From: Miroslav Benes
Date: Thu Apr 11 2019 - 15:04:10 EST



> diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> index 2472ce39a18d..8b9b42a258ad 100644
> --- a/samples/livepatch/Makefile
> +++ b/samples/livepatch/Makefile
> @@ -1,3 +1,4 @@
> +LIVEPATCH_livepatch-sample := y
> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-sample.o
> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-mod.o
> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix1.o

We discussed this and I think there has been no conclusion yet. Shouldn't
we do the same (add LIVEPATCH_) for the other samples here as well? So
they are not picked up by cmd_klp_map and their symbols stored in
Symbols.list?

Miroslav