Re: [PATCH] dns: remove redundant zero length namelen check

From: David Miller
Date: Thu Apr 11 2019 - 17:02:08 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 9 Apr 2019 13:59:12 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The zero namelen check is redundant as it has already been checked
> for zero at the start of the function. Remove the redundant check.
>
> Addresses-Coverity: ("Logically Dead Code")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to net-next.

However it does look like two sets of semantics were considered.
In one case rejecting a zero namelen and in another having it
mean whatever the strings length is modulo the max of 256.