Re: [RESEND PATCH 1/2] ARM: davinci: support multiplatform build for ARM v5

From: Arnd Bergmann
Date: Fri Apr 12 2019 - 09:45:12 EST


On Fri, Apr 12, 2019 at 3:32 PM Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
> pt., 12 kwi 2019 o 15:27 Arnd Bergmann <arnd@xxxxxxxx> napisaÅ(a):
> >
> > On Fri, Apr 12, 2019 at 3:22 PM Bartosz Golaszewski
> > <bgolaszewski@xxxxxxxxxxxx> wrote:
> > > pt., 12 kwi 2019 o 15:16 Arnd Bergmann <arnd@xxxxxxxx> napisaÅ(a):
> > > > On Tue, Apr 2, 2019 at 1:03 PM Sekhar Nori <nsekhar@xxxxxx> wrote:
> > > > > On 25/03/19 6:38 PM, Arnd Bergmann wrote:
> > > > > > On Mon, Mar 18, 2019 at 1:29 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > > > >
> > > > > The timer conversion patches are pending review/rework. Will queue once
> > > > > those are cleared.
> > > >
> > > > Unfortunately, after doing some more randconfig testing, I ended up with
> > > > three build issues:
> > > >
> > > > 1. vpbe:
> > > > drivers/media/platform/davinci/vpbe_osd.c:29:10: fatal error:
> > > > 'mach/cputype.h' file not found
> > > > #include <mach/cputype.h>
> > > > ^~~~~~~~~~~~~~~~
> > > > drivers/media/platform/davinci/vpbe_venc.c:26:10: fatal error:
> > > > 'mach/hardware.h' file not found
> > > > #include <mach/hardware.h>
> > > > ^~~~~~~~~~~~~~~~~
> > > > drivers/media/platform/davinci/vpbe_display.c:31:10: fatal error:
> > > > 'mach/cputype.h' file not found
> > > >
> > > > 2. staging/vpfe:
> > > > In file included from
> > > > /git/arm-soc/drivers/staging/media/davinci_vpfe/dm365_isif.c:20:
> > > > drivers/staging/media/davinci_vpfe/dm365_isif.h:24:10: fatal error:
> > > > 'mach/mux.h' file not found
> > > >
> > > > 3.
> > > > davinci: fix sleep.S build error on ARMv4
> > > >
> > > > When building a multiplatform kernel that includes armv4 support,
> > > > the default target CPU does not support the blx instruction,
> > > > which leads to a build failure:
> > > >
> > > > arch/arm/mach-davinci/sleep.S: Assembler messages:
> > > > arch/arm/mach-davinci/sleep.S:56: Error: selected processor does
> > > > not support `blx ip' in ARM mode
> > > >
> > >
> > > Hi Arnd,
> > >
> > > are the generated configs available somewhere for download?
> >
> > No, I only keep them locally, but I would hope they are easy enough to
> > reproduce. If you can't figure out the problem right away, I can send
> > you the config files of course.
> >
> > Just noticed another issue in my logs:
> >
> > 4. ARCH_DAVINCI no longer selects RESET_CONTROLLER
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x3f8): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x14): undefined reference to `reset_controller_add_lookup'
> >
> > Arnd
>
> Thanks. Another issue that I already fixed locally is missing select
> for REGMAP_MMIO. Just FYI.
>
> This series is blocked by the clocksource series anyway, but I'll work
> towards fixing it.

Ok, sounds good. I have sent you whatever I had to work around the
issue locally now, as private messages. See if you can use them, or
ignore if you have a better fix.

Arnd