Re: [PATCH v2] staging: erofs: fix unexpected out-of-bound data access

From: Gao Xiang
Date: Fri Apr 12 2019 - 10:38:24 EST




On 2019/4/12 21:51, Dan Carpenter wrote:
> On Fri, Apr 12, 2019 at 05:53:14PM +0800, Gao Xiang wrote:
>> Unexpected out-of-bound data will be read in erofs_read_raw_page
>> after commit 07173c3ec276 ("block: enable multipage bvecs") since
>> one iovec could have multiple pages.
>>
>> Let's fix as what Ming's pointed out in the previous email [1].
>>
>> [1] https://lore.kernel.org/lkml/20190411080953.GE421@xxxxxxxxxx/
>>
>
> Please also use the Fixes tag.
>
> Fixes: 07173c3ec276 ("block: enable multipage bvecs")

Thanks for reminder. Maybe Greg could add this line...

Thanks,
Gao Xiang

>
>> Suggested-by: Ming Lei <ming.lei@xxxxxxxxxx>
>> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
>> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>
>
> regards,
> dan carpenter
>