Re: [PATCH RFC 1/2] thermal/drivers/of: Add a get_temp_id callback function

From: Daniel Lezcano
Date: Sat Apr 13 2019 - 04:28:50 EST


On 13/04/2019 10:18, Andrey Smirnov wrote:
> On Thu, Apr 4, 2019 at 1:07 AM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
>>
>> Currently when we register a sensor, we specify the sensor id and a data
>> pointer to be passed when the get_temp function is called. However the
>> sensor_id is not passed to the get_temp callback forcing the driver to
>> do extra allocation and adding back pointer to find out from the sensor
>> information the driver data and then back to the sensor id.
>>
>> Add a new callback get_temp_id() which will be called if set. It will
>> call the get_temp_id() with the sensor id.
>>
>> That will be more consistent with the registering function.
>>
>
> Tested both patches on i.MX8MQ, seem to work as expected.
>
> Tested-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Great, thank you very much for testing!


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog