Re: [PATCH v2] drm: aspeed: Clean up Kconfig options

From: Daniel Vetter
Date: Mon Apr 15 2019 - 11:43:17 EST


On Mon, Apr 15, 2019 at 06:41:48PM +0800, Joel Stanley wrote:
> On Mon., 15 Apr. 2019, 17:32 Daniel Vetter, <daniel@xxxxxxxx> wrote:
>
> > On Fri, Apr 05, 2019 at 06:41:17PM +1030, Joel Stanley wrote:
> > > The GFX IP is inside of the ASPEED BMC SoC so there is little use
> > > enabling it on a kernel that does not support ASPEED.
> > >
> > > When building with COMPILE_TEST the architecture many not have CMA
> > > support, so to avoid breaking the build we only select these options if
> > > the architecture supports the contiguous allocator.
> > >
> > > I suspect the DRM_PANEL came from a cut/paste error.
> > >
> > > Fixes: 4f2a8f5898ec ("drm: Add ASPEED GFX driver")
> > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> >
> > Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> >
> > Iirc you have commit rights, right?
> >
>
> Can you please apply this one for me? I'm traveling and don't have my keys
> with me.

Ok, since it's holding up linux-next testing I've applied, in general it's
ok to just wait until you're back I think.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch