Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
From: Juergen Gross
Date: Tue Apr 16 2019 - 03:17:39 EST
On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ânetback_changedâ:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Juergen