Re: [PATCH] kernel/compat.c: mark expected switch fall-throughs

From: Arnd Bergmann
Date: Tue Apr 16 2019 - 05:14:55 EST


On Tue, Apr 16, 2019 at 10:54 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 16 Apr 2019 10:32:55 +0200 Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > We could also consider just getting rid of put_compat_sigset() and
> > get_compat_sigset() but replacing them with a combined
> > put_sigset()/get_sigset() that does the right thing for both native
> > and compat tasks. This lets us kill a couple of compat system
> > calls that only differ in their sigset_t argument. On little-endian
> > systems (which are the vast majority of the installed base), there
> > is no difference anyway there is no overhead anyway since
> > native and compat sigset_t are identical.
>
> That sounds like a bigger patch that would require some real testing :-)

Yes, definitely. I mainly mentioned it in case someone wants to
do that work anyway, as it would avoid the need for your patch.

Arnd