Re: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

[Borislav Petkov]

On Mon, Apr 15, 2019 at 11:00:25PM +0000, Junichi Nomura wrote:
> I thought we should hang here instead of return so that we
> don't run into efi_get_rsdp_addr() in case of kexec.

Hanging that early without debug output is not very friendly to
debuggers, methinks.

> > +	ei = &boot_params->efi_info;
> > +	sig = (char *)&ei->efi_loader_signature;
> > +	if (strncmp(sig, EFI64_LOADER_SIGNATURE, 4)) {
> > +		debug_putstr("Wrong kexec EFI loader signature.\n");
> > +		return 0;
> > +	}
> 
> Same here.

Ditto.

You get the idea.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.