Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static
From: Lorenzo Pieralisi
Date: Tue Apr 16 2019 - 06:08:45 EST
On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Fix sparse warning:
>
> drivers/pci/controller/pci-mvebu.c:557:28: warning:
> symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/pci/controller/pci-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/misc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
> index d3a0419..ed032e9 100644
> --- a/drivers/pci/controller/pci-mvebu.c
> +++ b/drivers/pci/controller/pci-mvebu.c
> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
> }
> }
>
> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
> .write_base = mvebu_pci_bridge_emul_base_conf_write,
> .read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
> .write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
> --
> 2.7.4
>
>