Re: [PATCH v2 27/36] drivers: Add a generic helper to match device by fwnode handle
From: Rafael J. Wysocki
Date: Tue Apr 16 2019 - 06:21:13 EST
On Mon, Apr 15, 2019 at 6:06 PM Suzuki K Poulose <suzuki.poulose@xxxxxxx> wrote:
>
> Make the device_fwnode_match() a generic helper to match device
> by fwnode handle for use with bus_find_device(). This will be
> also used by coresight.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
Can you resend this with a CC to linux-acpi@xxxxxxxxxxxxxxx, please?
There's some device properties material for 5.2 collected already and
it would be good to keep all that together.
> ---
> drivers/base/devcon.c | 5 -----
> drivers/base/property.c | 6 ++++++
> include/linux/property.h | 1 +
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/base/devcon.c b/drivers/base/devcon.c
> index 04db9ae..f4a9e30 100644
> --- a/drivers/base/devcon.c
> +++ b/drivers/base/devcon.c
> @@ -107,11 +107,6 @@ static struct bus_type *generic_match_buses[] = {
> NULL,
> };
>
> -static int device_fwnode_match(struct device *dev, void *fwnode)
> -{
> - return dev_fwnode(dev) == fwnode;
> -}
> -
> static void *device_connection_fwnode_match(struct device_connection *con)
> {
> struct bus_type *bus;
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 8b91ab3..d10d923 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -25,6 +25,12 @@ struct fwnode_handle *dev_fwnode(struct device *dev)
> }
> EXPORT_SYMBOL_GPL(dev_fwnode);
>
> +int device_fwnode_match(struct device *dev, void *fwnode)
> +{
> + return dev_fwnode(dev) == fwnode;
> +}
> +EXPORT_SYMBOL_GPL(device_fwnode_match);
> +
> /**
> * device_property_present - check if a property of a device is present
> * @dev: Device whose property is being checked
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 65d3420..c8fd3d42 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -34,6 +34,7 @@ enum dev_dma_attr {
> };
>
> struct fwnode_handle *dev_fwnode(struct device *dev);
> +int device_fwnode_match(struct device *dev, void *fwnode);
>
> bool device_property_present(struct device *dev, const char *propname);
> int device_property_read_u8_array(struct device *dev, const char *propname,
> --
> 2.7.4
>