Re: [PATCH v3] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver

From: David Woodhouse
Date: Tue Apr 16 2019 - 09:14:07 EST


On Tue, 2019-04-09 at 08:57 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2019-03-28 at 13:57 +0200, Jonathan Chocron wrote:
> > Add support for Amazon's Annapurna Labs PCIe driver. The HW
> > controller
> > is based on DesignWare's IP.
> >
> > The HW doesn't support accessing the Root Port's config space via
> > ECAM,
> > so we obtain its base address via an AMZN0001 device.
> >
> > Furthermore, the DesignWare PCIe controller doesn't filter out
> > config
> > transactions sent to devices 1 and up on its bus, so they are
> > filtered
> > by the driver.
> >
> > All subordinate buses do support ECAM access.
> >
> > Implementing specific PCI config access functions involves:
> > - Adding an init function to obtain the Root Port's base address
> > from
> > an AMZN0001 device.
> > - Adding a new entry in the MCFG quirk array
> >
> > Co-developed-by: Vladimir Aerov <vaerov@xxxxxxxxxx>
> > Signed-off-by: Jonathan Chocron <jonnyc@xxxxxxxxxx>
> > Signed-off-by: Vladimir Aerov <vaerov@xxxxxxxxxx>
> > Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Late to the party, sorry :-) That kernel.crashing.org email is on its
> last legs...
>
> Reviewed-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

Lorenzo, is there anything else you need from Jonny before this can be
applied?

Thanks.

Attachment: smime.p7s
Description: S/MIME cryptographic signature