Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary

[Andrew Morton]

On Thu, 11 Apr 2019 18:06:23 +0900 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:

> On Sat, Mar 23, 2019 at 10:55 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > If you drop into kdb and type "summary", it prints out a line that
> > says this:
> >
> >   ccversion  CCVERSION
> >
> > ...and I don't mean that it actually prints out the version of the C
> > compiler.  It literally prints out the string "CCVERSION".
> >
> > The version of the C Compiler is already printed at boot up and it
> > doesn't seem useful to replicate this in kdb.  Let's just delete it.
> > We can also delete the bit of the Makefile that called the C compiler
> > in an attempt to pass this into kdb.  This will remove one extra call
> > to the C compiler at Makefile parse time and (very slightly) speed up
> > builds.
> >
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> 
> 
> I know you add lots of Cc: lines
> when you pick up patches, but I think
> your script can be improved.
> 
> You added "Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>",
> but Douglas is the author.
> I think the author should be excluded from Cc.

Whoops.

It's pretty benign: Doug will still only get a single email.


checkpatch checks for duplicates cc's but I think it assumes that
things like

Reported-by: fred
Tested-by: fred

were intentional.

It would perhaps be better for checkpatch to special-case the "Cc:
fred" tag and report a duplicated Cc: if fred was also mentioned in any
other tag.