Re: [PATCH v4 0/2] cpufreq: Add sunxi nvmem based CPU scaling driver

[Maxime Ripard]

On Wed, Apr 17, 2019 at 07:38:30AM +0530, Viresh Kumar wrote:
> On 16-04-19, 11:52, Yangtao Li wrote:
> > Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo.
> >
> > Yangtao Li (2):
> >   cpufreq: Add sunxi nvmem based CPU scaling driver
> >   dt-bindings: cpufreq: Document allwinner,sun50i-h6-operating-points
> >
> >  .../bindings/opp/sun50i-nvmem-cpufreq.txt     | 167 +++++++++++++
> >  MAINTAINERS                                   |   7 +
> >  drivers/cpufreq/Kconfig.arm                   |  12 +
> >  drivers/cpufreq/Makefile                      |   1 +
> >  drivers/cpufreq/cpufreq-dt-platdev.c          |   2 +
> >  drivers/cpufreq/sun50i-cpufreq-nvmem.c        | 226 ++++++++++++++++++
> >  6 files changed, 415 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/opp/sun50i-nvmem-cpufreq.txt
> >  create mode 100644 drivers/cpufreq/sun50i-cpufreq-nvmem.c
> >
> > ---
> > v4:
> > -I removed this sunxi_cpufreq_soc_data structure for now.
>
> Why this change ?

It's used on a single SoC for now, so it's impossible to know at this
point what to put in that structure in the first place.

Of course, that would need to be brought back if we ever have two SoCs
to support and that we know which differences there is.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature