Re: [PATCH] regulator: core: do not report EPROBE_DEFER as error.

[Jorge Ramirez]

On 4/17/19 17:46, Mark Brown wrote:
> On Wed, Apr 17, 2019 at 10:54:11AM +0200, Jorge Ramirez-Ortiz wrote:
>> Do not log a temporary failure to get a regulator (EPROBE_DEFER) while
>> the driver is requesting retries.
> 
>> -			dev_err(dev, "Failed to get supply '%s': %d\n",
>> -				consumers[i].supply, ret);
>> +			if (ret != -EPROBE_DEFER)
>> +				dev_err(dev, "Failed to get supply '%s': %d\n",
>> +					consumers[i].supply, ret);
> 
> Please leave at least a debug log in place, it's not good to just
> silently fail - even if we will retry someone might still need some help
> debugging (eg, figuring out that they need to enable whatever driver is
> providing the supply in their config) so we should tell them why we're
> deferring.


you mean replacing dev_err with dev_dbg on all cases or only on defer
leaving  dev_err on the rest?


> 
> BTW does an e-mail address need updating somewhere here?
> 

dont know, whose email? I got these from get_maintainer.pl (below); or
are you referring to mine (in which case it is correct, I am back at
least for a bit longer)

Liam Girdwood <lgirdwood@xxxxxxxxx> (supporter:VOLTAGE AND CURRENT
REGULATOR FRAMEWORK)
Mark Brown <broonie@xxxxxxxxxx> (supporter:VOLTAGE AND CURRENT REGULATOR
FRAMEWORK)
linux-kernel@xxxxxxxxxxxxxxx (open list:VOLTAGE AND CURRENT REGULATOR
FRAMEWORK)