Re: [patch V2 03/29] lib/stackdepot: Provide functions which operate on plain storage arrays

From: Thomas Gleixner
Date: Thu Apr 18 2019 - 07:59:39 EST


On Thu, 18 Apr 2019, Mike Rapoport wrote:
> On Thu, Apr 18, 2019 at 10:41:22AM +0200, Thomas Gleixner wrote:
> >
> > -void depot_fetch_stack(depot_stack_handle_t handle, struct stack_trace *trace)
> > +/**
> > + * stack_depot_fetch - Fetch stack entries from a depot
> > + *
>
> Nit: kernel-doc will complain about missing description of @handle.

Duh.

> > + * @entries: Pointer to store the entries address
> > + */
>
> Can you please s/Returns/Return:/ so that kernel-doc will recognize this as
> return section.

Sure thing.

Thanks,

tglx