Re: [linux-sunxi] Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO

[Pablo SebastiÃn Greco]

El 17/4/19 a las 07:17, Maxime Ripard escribiÃ:
> Hi,
>
> On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote:
> > When the GMAC support was added to the bananapi-m2-ultra, regulators
> > weren't tied to the pinctrl. Fix that.
> >
> > Signed-off-by: Pablo Greco <pgreco@xxxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > index c488aaa..3da3598 100644
> > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> > @@ -201,6 +201,8 @@
> >   &pio {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&clk_out_a_pin>;
> > +	vcc-pa-supply = <&reg_aldo2>;
> You should list all the regulators that are needed for all the pin
> banks to operate properly, not just PA
Ok, I "think" I finally understand what you mean, so according to 
schematics in 
https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it 
should look like this
diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts 
b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index c488aaa..699579d 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -201,6 +201,12 @@
Â&pio {
ÂÂÂÂ pinctrl-names = "default";
ÂÂÂÂ pinctrl-0 = <&clk_out_a_pin>;
+ÂÂÂ vcc-pa-supply = <&reg_aldo2>;
+ÂÂÂ vcc-pc-supply = <&reg_dcdc1>;
+ÂÂÂ vcc-pd-supply = <&reg_dcdc1>;
+ÂÂÂ vcc-pe-supply = <&reg_eldo1>;
+ÂÂÂ vcc-pf-supply = <&reg_dcdc1>;
+ÂÂÂ vcc-pg-supply = <&reg_dldo1>;
Â};

Â&reg_aldo2 {
--

I couldn't find vcc-pb, vcc-ph or vcc-pi.
If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash 
where it belongs
> > +	vcc-gmac-phy-supply = <&reg_dc1sw>;
> I'm not sure what that is supposed to do?
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Pablo.