Re: [PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support
From: Nick Crews
Date: Thu Apr 18 2019 - 11:42:52 EST
There's one error that Guenter just found...
> +
> +int wilco_ec_add_sysfs(struct wilco_ec_device *ec)
> +{
> + return sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group);
> +}
> +
> +void wilco_ec_remove_sysfs(struct wilco_ec_device *ec)
> +{
> + sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group);
Should be sysfs_remove_group()