Re: [PATCH -next] scsi: lpfc: Make lpfc_sli4_oas_verify static

[James Smart]

On 4/17/2019 8:05 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_init.c:13091:1: warning:
>   symbol 'lpfc_sli4_oas_verify' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>   drivers/scsi/lpfc/lpfc_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 8e0de48..eaaef68 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -13087,7 +13087,7 @@ lpfc_io_resume(struct pci_dev *pdev)
>    * is destroyed.
>    *
>    **/
> -void
> +static void
>   lpfc_sli4_oas_verify(struct lpfc_hba *phba)
>   {
>   

Looks good. Interesting as there's a prototype for the function earlier 
which defines it as static.

Reviewed-by: James Smart <james.smart@xxxxxxxxxxxx>

-- james