Re: [PATCH v3 4/4] samples: show race-free pidfd metadata access

From: Christian Brauner
Date: Fri Apr 19 2019 - 14:27:41 EST


On Fri, Apr 19, 2019 at 05:30:48PM +0200, Oleg Nesterov wrote:
> On 04/19, Christian Brauner wrote:
> >
> > +int main(int argc, char *argv[])
> > +{
> > + int ret = EXIT_FAILURE;
> > + char buf[4096] = { 0 };
> > + pid_t pid;
> > + int pidfd, procfd, statusfd;
>
> I think you need to initialize pidfd = 0 in this version ;) Otherwise,

Yes, you are right. Seems I got saved by the compiler since I compile a
kernel and run a test even when i just change the commit message. :)
Will fix that up and add your Reviewed-by but I think I spare everyone
a v4 for this if that's ok.

>
> Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Thank you!
Christian