Re: [alsa-devel] [PATCH v3 0/5] soundwire: code cleanup

[Pierre-Louis Bossart]

On 4/15/19 7:57 AM, Pierre-Louis Bossart wrote:
> On 4/14/19 5:04 AM, Vinod Koul wrote:
> > On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
> > > SoundWire support will be provided in Linux with the Sound Open
> > > Firmware (SOF) on Intel platforms. Before we start adding the missing
> > > pieces, there are a number of warnings and style issues reported by
> > > checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
> >
> > Applied, 1, 3 and 4 (5 looked good but didnt apply)
>
> this applies on top of Mark Brown's for-next tree. This should be the 
> reference really for SoundWire work, if we start having another tree 
> with deltas it's really counter productive. I already have dependencies 
> on acpi...

Vinod, can you please double-check why patch 5 didn't work for you. I 
tried on Mark and Linus' trees and no issues, see below.

$ git reset --hard v5.1-rc5
HEAD is now at dc4060a5dc25 Linux 5.1-rc5

$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs

$ git reset --hard broonie/for-next
HEAD is now at 84fdefca04a7 Merge branch 'asoc-5.2' into asoc-next

$ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml
Applying: soundwire: intel: fix inversion in devm_kcalloc parameters
Applying: soundwire: fix style issues
Applying: soundwire: bus: remove useless initializations
Applying: soundwire: stream: remove useless initialization of local variable
Applying: soundwire: add missing newlines in dynamic debug logs