Re: [PATCH 5.0 18/93] paride/pf: cleanup queues when detection fails

[Sasha Levin]

On Fri, Apr 19, 2019 at 07:13:40AM +0000, nobuhiro1.iwamatsu@xxxxxxxxxxxxx wrote:
> Hi,
>
> > [ Upstream commit 6ce59025f1182125e75c8d121daf44056b65dd1f ]
> >
> > The driver allocates queues for all the units it potentially
> > supports. But if we fail to detect any drives, then we fail
> > loading the module without cleaning up those queues. This is
> > now evident with the switch to blk-mq, though the bug has
> > been there forever as far as I can tell.
> >
> > Also fix cleanup through regular module exit.
> >
> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> This commit causes a new problem. And the commit that made the fix
> is 58ccd2d31e502c37e108b285bf3d343eb00c235b.
> I think this commit needs to be applied together.

I've queued up this fix, thank you!

--
Thanks,
Sasha