Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload support

From: David Miller
Date: Fri Apr 19 2019 - 18:09:54 EST


From: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
Date: Fri, 19 Apr 2019 15:30:27 +0200

> +/* Internal represention of a Flow Steering rule */
> +struct mvpp2_rfs_rule {
> + /* Rule location inside the flow*/
> + int loc;
> +
> + /* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
> + int flow_type;
> +
> + /* The lookup type used by this flow. This allows the classification
> + * engines to differentiate between entries that match the same
> + * parameters
> + */
> + int lu_type;
> +
> + /* Index of the entry handling this rule in the flow table */
> + int flt_index;
> +
> + /* Index of the C2 TCAM entry handling this rule */
> + int c2_index;

On 64-bit there will be a 32-bit hole here. Why not put hek_fields
and engine here?