Re: [PATCHv2] selftests/efivarfs: clean up test files from test_create*()
From: Po-Hsu Lin
Date: Fri Apr 19 2019 - 18:45:43 EST
Hello,
Commit f8a0590f fix some part of this issue.
I will send out V3 base on this commit in linux-kselftest next branch.
Thank you.
On Fri, Apr 19, 2019 at 9:20 PM shuah <shuah@xxxxxxxxxx> wrote:
>
> On 4/19/19 7:12 AM, Po-Hsu Lin wrote:
> > Test files created by test_create*() tests will stay in the
> > $efivarfs_mount directory unless the system was rebooted.
> >
> > When the tester tries to run this efivarfs test again on the same
> > system, the immutable characteristics in that directory will cause some
> > "Operation not permitted" noises and a false-positve test result to the
> > test_create_read() test.
> >
> > --------------------
> > running test_create
> > --------------------
> > ./efivarfs.sh: line 59: /sys/firmware/efi/efivars/test_create-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
> > [PASS]
> > --------------------
> > running test_create_empty
> > --------------------
> > ./efivarfs.sh: line 78: /sys/firmware/efi/efivars/test_create_empty-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
> > [PASS]
> > --------------------
> > running test_create_read
> > --------------------
> > open(O_WRONLY): Operation not permitted
> > [FAIL]
> > --------------------
> >
> > Create a file_cleanup() to remove those test files in the end of each
> > test to solve this issue.
> >
> > Also, use this function to replace the existing file removal code.
> >
> > Link: https://bugs.launchpad.net/bugs/1809704
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx>
> > ---
>
> Thanks for the patch. There is another patch that does the same in
> linux-kselftest next branch.
>
> Please check to see if that fixes the problem you are seeing.
>
> thanks,
> -- Shuah
>