Re: [PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc()

From: Peter Rosin
Date: Sun Apr 21 2019 - 14:15:36 EST


On 2019-01-04 19:06, Wolfram Sang wrote:
>
>> Instead of leaving these open-coded and prone to type mistakes, we can
>> now use the new struct_size() helper:
>
> I am okay with this patch in general. However, I think the name of the
> helper 'struct_size' is a bit unfortunate. I really wondered on the
> first read why it needs 3 arguments to find out a struct size. I only
> understood on the second read. I think 'trailing_array_struct_size'
> would be way more clearer what it does.

I read that as an Acked-by... :-)

Cheers,
Peter