RE: [PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver support

[Anson Huang]

Hi, Shawn

Best Regards!
Anson Huang

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: Sunday, April 21, 2019 3:42 PM
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: stefan.wahren@xxxxxxxx; enric.balletbo@xxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; heiko@xxxxxxxxx; marc.w.gonzalez@xxxxxxx;
> ezequiel@xxxxxxxxxxxxx; catalin.marinas@xxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; will.deacon@xxxxxxx; Abel Vesa
> <abel.vesa@xxxxxxx>; bjorn.andersson@xxxxxxxxxx; Andy Gross
> <andy.gross@xxxxxxxxxx>; jagan@xxxxxxxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; olof@xxxxxxxxx;
> horms+renesas@xxxxxxxxxxxx; festevam@xxxxxxxxx; robh@xxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; l.stach@xxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver
> support
> 
> On Sun, Apr 21, 2019 at 03:40:00PM +0800, Shawn Guo wrote:
> > On Thu, Apr 11, 2019 at 06:49:12AM +0000, Anson Huang wrote:
> > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > > inside, the system controller is in charge of controlling power,
> > > clock and fuse etc..
> > >
> > > This patch adds i.MX system controller soc driver support, Linux
> > > kernel has to communicate with system controller via MU (message
> > > unit) IPC to get soc revision, uid etc..
> > >
> > > With this patch, soc info can be read from sysfs:
> > >
> > > i.mx8qxp-mek# cat /sys/devices/soc0/family Freescale i.MX
> > >
> > > i.mx8qxp-mek# cat /sys/devices/soc0/soc_id i.MX8QXP
> > >
> > > i.mx8qxp-mek# cat /sys/devices/soc0/machine Freescale i.MX8QXP MEK
> > >
> > > i.mx8qxp-mek# cat /sys/devices/soc0/revision
> > > 1.1
> > >
> > > i.mx8qxp-mek# cat /sys/devices/soc0/soc_uid
> > > 7B64280B57AC1898
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > > ---
> > >  drivers/soc/imx/Kconfig      |   7 ++
> > >  drivers/soc/imx/Makefile     |   1 +
> > >  drivers/soc/imx/soc-imx-sc.c | 220
> > > +++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 228 insertions(+)
> > >  create mode 100644 drivers/soc/imx/soc-imx-sc.c
> >
> > Rather than creating a new driver, please take a look at Abel's
> > generic
> > i.MX8 SoC driver, and see if it can be extended to cover i.MX8QXP.
> 
> Forgot to give pointer to Abel's driver.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker
> nel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fshawnguo%2Flinux.git%
> 2Fcommit%2F%3Fh%3Dimx%2Fdrivers%26id%3Da7e26f356ca12906a164d83c
> 9e9f8527ee7da022&amp;data=02%7C01%7Canson.huang%40nxp.com%7C9
> e2705d7449b4c2e23ed08d6c62ce0bb%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C636914293400307709&amp;sdata=6ySEs%2B4SE8bvcBCkfoi
> VBafseAYthTED9%2F5qcf25xds%3D&amp;reserved=0
> 

Got it, I didn't notice that this patch bas been accepted, I will redo the patch based on it,
thanks.

Anson.

> Shawn