Re: [PATCH v20 09/28] x86/sgx: Add ENCLS architectural error codes
From: Sean Christopherson
Date: Mon Apr 22 2019 - 17:35:40 EST
On Wed, Apr 17, 2019 at 01:39:19PM +0300, Jarkko Sakkinen wrote:
> The SGX architecture defines an extensive set of error codes that are
> used by ENCL{S,U,V} instructions to provide software with (somewhat)
> precise error information. Though they are architectural, define the
> known error codes in a separate file from sgx_arch.h so that they can
> be exposed to userspace. For some ENCLS leafs, e.g. EINIT, returning
> the exact error code on failure can enable userspace to make informed
> decisions when an operation fails.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> Co-developed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> ---
Your SOB needs to be last. Several other patches have the same issue,
e.g. 10-13, 15 and 17.
See commit 24a2bb90741b ("docs: Clarify the usage and sign-off requirements
for Co-developed-by") in branch docs-next of git://git.lwn.net/linux.git.