Re: [PATCH v3 07/10] iommu/vt-d: Keep swiotlb on if bounce page is necessary

From: Lu Baolu
Date: Mon Apr 22 2019 - 22:06:46 EST


Hi,

On 4/23/19 12:47 AM, Christoph Hellwig wrote:
On Sun, Apr 21, 2019 at 09:17:16AM +0800, Lu Baolu wrote:
+static inline bool platform_has_untrusted_device(void)
{
+ bool has_untrusted_device = false;
struct pci_dev *pdev = NULL;
for_each_pci_dev(pdev) {
if (pdev->untrusted) {
+ has_untrusted_device = true;
break;
}
}
+ return has_untrusted_device;

This shouldn't really be in the intel-iommu driver, should it?
This probably should be something like pci_has_untrusted_devices
and be moved to the PCI code.


Fair enough.

Best regards,
Lu Baolu