Re: [PATCH v3 08/10] iommu/vt-d: Check whether device requires bounce buffer

[Lu Baolu]

Hi,

On 4/23/19 12:47 AM, Christoph Hellwig wrote:
> On Sun, Apr 21, 2019 at 09:17:17AM +0800, Lu Baolu wrote:
> > +static inline bool device_needs_bounce(struct device *dev)
> > +{
> > +	struct pci_dev *pdev = NULL;
> > +
> > +	if (intel_no_bounce)
> > +		return false;
> > +
> > +	if (dev_is_pci(dev))
> > +		pdev = to_pci_dev(dev);
> > +
> > +	return pdev ? pdev->untrusted : false;
> > +}
>
> Again, this and the option should not be in a specific iommu driver.

The option of whether bounce is ignored should be in the specific iommu
driver. Or any other thought?

Best regards,
Lu Baolu