Re: [PATCH 2/3] spi: lpspi: add multi SS support in PIO mode

From: Fabio Estevam
Date: Tue Apr 23 2019 - 07:21:41 EST


On Tue, Apr 23, 2019 at 7:48 AM Clark Wang <xiaoning.wang@xxxxxxx> wrote:
>
> Add "fsl,spi-num-chipselects" check to support multi SS function in PIO
> mode.

This custom property does not seem to be needed as the number of chip
selects can be parsed from the devicetree file directly.

We got rid of "fsl,spi-num-chipselects" property in the spi-imx driver
in this commit:

commit b36581df7e788b674a4efbb8da7fe4a00c207e8b
Author: Alexander Shiyan <shc_work@xxxxxxx>
Date: Wed Jun 8 20:02:06 2016 +0300

spi: imx: Using existing properties for chipselects

Patch reuse existing "chip_select" and "cs_gpio(s)" fields from SPI core.

Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

and we should try to also avoid such property in spi-fsl-lpspi as well.