Re: [PATCH v3 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS

[Peter Ujfalusi]

Hi Thierry,

On 23/04/2019 14.55, Thierry Reding wrote:
> On Tue, Feb 26, 2019 at 09:55:19AM +0200, Peter Ujfalusi wrote:
>> Hi,
>>
>> Changes since v2:
>> - Added Reviewed-by from Rob to the binding patches
>> - Added help text to Kconfig (osd101t2587-53ts)
>> - Print the error values in dev_err/warn
>> - Added Reviewed-by from Sam to the osd101t2587-53ts patch
>>
>> Changes since v1 (only panel-osd-osd101t2587-53ts changed):
>> - Removed unused members from struct osd101t2587_panel
>> - Use backlight_enable/backlight_disable
>> - Use devm_of_find_backlight()
>> - osd101t2587_of_match table standardized 
>> - osd101t2587_panel_unprepare() added to shutdown and remove callbacks to turn
>>   power off
>> - Fix probe in case mipi_dsi_attach() would fail
>>
>> Add support for OSD101T2045-53TS and OSD101T2587-53TS from One Stop Displays.
>>
>> The two panel is similar with one big difference: OSD101T2587-53TS requires the
>> MIPI_DSI_TURN_ON_PERIPHERAL message, thus can not be handled by panel-simple.
>>
>> Regards,
>> Peter
>> ---
>> Peter Ujfalusi (4):
>>   dt-bindings: display: Add bindings for OSD101T2045-53TS
>>   drm/panel: simple: Add support for OSD101T2045-53TS
>>   dt-bindings: display: Add bindings for OSD101T2587-53TS panel
>>   drm/panel: Add OSD101T2587-53TS driver
>>
>>  .../display/panel/osd,osd101t2045-53ts.txt    |  11 +
>>  .../display/panel/osd,osd101t2587-53ts.txt    |  14 +
>>  drivers/gpu/drm/panel/Kconfig                 |   9 +
>>  drivers/gpu/drm/panel/Makefile                |   1 +
>>  .../drm/panel/panel-osd-osd101t2587-53ts.c    | 254 ++++++++++++++++++
>>  drivers/gpu/drm/panel/panel-simple.c          |  34 +++
>>  6 files changed, 323 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/osd,osd101t2045-53ts.txt
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/osd,osd101t2587-53ts.txt
>>  create mode 100644 drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> 
> Applied all four patches. Note that I had to change the osd vendor
> string to osddisplays, which is the one that is documented in
> vendor-prefixes.txt.

I recall checking the vendor-prefixes.txt and not finding OSD in there.
Odd, as it is indeed there.

> I'm assuming that this is the same vendor, based on the model names. If
> this is a different vendor, do let me know.

Yes it is the same one.

Thank you and sorry for missing it,
- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki