Re: [PATCH v12 07/31] mm: make pte_unmap_same compatible with SPF

[Matthew Wilcox]

On Tue, Apr 16, 2019 at 03:44:58PM +0200, Laurent Dufour wrote:
> +static inline vm_fault_t pte_unmap_same(struct vm_fault *vmf)
>  {
> -	int same = 1;
> +	int ret = 0;

Surely 'ret' should be of type vm_fault_t?

> +			ret = VM_FAULT_RETRY;

... this should have thrown a sparse warning?