Re: Fwd: [PATCH 1/2] hwmon: (lm75) Add support for TMP75B
From: Guenter Roeck
Date: Wed Apr 24 2019 - 13:37:44 EST
On Wed, Apr 24, 2019 at 03:10:38PM +0100, Iker Perez del Palomar wrote:
> Hi,
>
>
> Thank you for the review, I will submitted fixed soon. I have one question
> before doing it though, after running scrips/chechpatch.sh I obtain the next
> message:
>
> WARNING: DT compatible string "ti,tmp75b" appears un-documented -- check ./Documentation/devicetree/bindings/
> #83: FILE: drivers/hwmon/lm75.c:549:
> + .compatible = "ti,tmp75b",
>
> total: 0 errors, 1 warnings, 60 lines checked
>
> So I added the next in
> "Documentation/devicetree/bindings/trivial-devices.yaml":
>
> - ti,amc6821
> # I2C Touch-Screen Controller
> - ti,tsc2003
> + # Digital Temperature Sensor with Two-Wire Interface and Alert
> + - ti,tmp75b
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> - ti,tmp102
> # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
>
>
> Is that the proper procedure??
It would make more sense to add it to
Documentation/devicetree/bindings/hwmon/lm75.txt
since this is where most of the lm75 compatible chips are listed.
Thanks,
Guenter