Re: [PATCH] selftests : netfilter: Wrote a error and exit code for a command which needed veth kernel module.

From: shuah
Date: Thu Apr 25 2019 - 15:43:42 EST


On 4/13/19 6:39 AM, Jeffrin Thalakkottoor wrote:
Hello Shuah,

did you get the mail related stuff below ?


Yes I saw this patch.

On Fri, Apr 5, 2019 at 10:17 PM Florian Westphal <fw@xxxxxxxxx> wrote:

Jeffrin Jose T <jeffrin@xxxxxxxxxxxxxxxxxxx> wrote:
A test for the basic NAT functionality uses ip command which
needs veth device.There is a condition where the kernel support
for veth is not compiled into the kernel and the test script
breaks.This patch contains code for reasonable error display
and correct code exit.

Looks good to me, thanks for following up on this.

Acked-by: Florian Westphal <fw@xxxxxxxxx>




Pablo,

Would you like me to take this patch through ksleftest tree?
If you want to take this through netfilter tree:

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah