RE: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/
From: yamada.masahiro
Date: Thu Apr 25 2019 - 22:25:06 EST
Hi Dave,
> -----Original Message-----
> From: Dave Airlie [mailto:airlied@xxxxxxxxx]
> Sent: Friday, April 26, 2019 11:19 AM
> To: Yamada, Masahiro/åç çå <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>;
> dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; nouveau
> <nouveau@xxxxxxxxxxxxxxxxxxxxx>; Sam Ravnborg <sam@xxxxxxxxxxxx>; David
> (ChunMing) Zhou <David1.Zhou@xxxxxxx>; amd-gfx mailing list
> <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; James (Qian) Wang
> <james.qian.wang@xxxxxxx>; Ben Skeggs <bskeggs@xxxxxxxxxx>;
> linux-arm-msm <linux-arm-msm@xxxxxxxxxxxxxxx>; Intel Graphics
> Development <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>;
> intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; Christian KÃnig
> <christian.koenig@xxxxxxx>; Alex Deucher <alexander.deucher@xxxxxxx>;
> freedreno@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with
> $(srctree)/
>
> On Fri, 26 Apr 2019 at 11:46, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >
> > Hi.
> >
> >
> > On Fri, Mar 29, 2019 at 8:37 PM Masahiro Yamada
> > <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > >
> > > Currently, the Kbuild core manipulates header search paths in a crazy
> > > way [1].
> > >
> > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> > > the search paths in the srctree. Some Makefiles are already written
> in
> > > that way, but not all. The goal of this work is to make the notation
> > > consistent, and finally get rid of the gross hacks.
> > >
> > > Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
> > > ("kbuild: do not drop -I without parameter").
> > >
> > > [1]: https://patchwork.kernel.org/patch/9632347/
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > > ---
> > >
> > > I put all gpu/drm changes into a single patch because
> > > they are trivial conversion.
> > >
> > > If you are interested in the big picture of this work,
> > > the full patch set is available at the following URL.
> > >
> > >
> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.g
> it build-test
> >
> >
> > Is somebody taking care of this?
> >
>
> Are you expecting this to be merged in the drm tree? if so please
> indicate that when posting.
Sorry for unclearness.
Could you apply this to your drm tree?
Thanks.
> I'd assumed this would go via kbuild tree.
>
> If the later,
> Acked-by: Dave Airlie <airlied@xxxxxxxxxx>
> Dave.